Skip to content

멘토 체크 API 호출 최적화 및 멘토 페이지 이동 버그 수정#420

Closed
manNomi wants to merge 3 commits intomainfrom
optimize/bundle-size
Closed

멘토 체크 API 호출 최적화 및 멘토 페이지 이동 버그 수정#420
manNomi wants to merge 3 commits intomainfrom
optimize/bundle-size

Conversation

@manNomi
Copy link
Contributor

@manNomi manNomi commented Feb 14, 2026

Summary

  • auth 전역 스토어에 userRole 상태를 추가해 토큰 파싱 결과를 일관되게 재사용하도록 정리했습니다.
  • 멘토 신규 신청 카운트 API 호출을 MENTOR 권한 사용자에게만 실행되도록 조건을 강화했습니다.
  • 멘토 알림 배너 클릭 시 /mentor 이동이 확실히 동작하도록 네비게이션 로직을 보강했습니다.

Verification

  • pnpm run typecheck 통과
  • pnpm run build 통과

@vercel
Copy link

vercel bot commented Feb 14, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
solid-connect-web-admin Error Error Feb 14, 2026 10:41am
solid-connection-web Error Error Feb 14, 2026 10:41am

@coderabbitai
Copy link

coderabbitai bot commented Feb 14, 2026 •
edited
Loading

Warning

Rate limit exceeded

@manNomi has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 15 minutes and 46 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Walkthrough

이 변경사항은 모달 렌더링 구조를 재설정하고 인증 로직을 토큰 기반에서 상태 저장소 기반으로 전환합니다. 주요 내용은 다음과 같습니다:

  1. ServerModal 제거 - RootModal에서 ServerModal 렌더링 제거, ClientModal만 남음
  2. ClientModal 구조 개선 - MentorApplyCountModal을 추가하여 배열 형태의 다중 요소 반환
  3. 인증 상태 관리 확장 - useAuthStore에 userRole 및 refreshStatus 필드 추가
  4. 역할 기반 검증 전환 - 토큰 파싱 방식에서 useAuthStore의 userRole 직접 읽기로 변경
  5. 네비게이션 방식 개선 - Link 컴포넌트에서 router.push 기반 네비게이션으로 전환

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Suggested reviewers

  • wibaek
  • enunsnv
  • khwww
🚥 Pre-merge checks | ✅ 3 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Merge Conflict Detection ⚠️ Warning ❌ Merge conflicts detected (22 files):

⚔️ .gitignore (content)
⚔️ .husky/pre-commit (content)
⚔️ .husky/pre-push (content)
⚔️ apps/web/package.json (content)
⚔️ apps/web/src/apis/mentor/getUnconfirmedMentoringCount.ts (content)
⚔️ apps/web/src/apis/mentor/index.ts (content)
⚔️ apps/web/src/app/university/list/[homeUniversityName]/page.tsx (content)
⚔️ apps/web/src/app/university/page.tsx (content)
⚔️ apps/web/src/components/layout/RootModal/index.tsx (content)
⚔️ apps/web/src/components/layout/RootModal/ui/ClientModal/index.tsx (content)
⚔️ apps/web/src/components/layout/TopDetailNavigation.tsx (content)
⚔️ apps/web/src/components/mentor/MentorApplyCountContent/index.tsx (content)
⚔️ apps/web/src/components/mentor/MentorExpandChatCard/hooks/useExpandCardClickHandler.ts (content)
⚔️ apps/web/src/components/ui/UniverSityCard/index.tsx (content)
⚔️ apps/web/src/components/university/UniversityCards/index.tsx (content)
⚔️ apps/web/src/constants/university.ts (content)
⚔️ apps/web/src/lib/zustand/useAuthStore.ts (content)
⚔️ apps/web/src/types/university.ts (content)
⚔️ docs/development-workflow.md (content)
⚔️ package.json (content)
⚔️ pnpm-lock.yaml (content)
⚔️ turbo.json (content)

These conflicts must be resolved before merging into main.		 Resolve conflicts locally and push changes to this branch.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed PR 제목이 주요 변경사항을 명확하게 반영합니다: API 호출 최적화와 버그 수정이라는 두 가지 핵심 목표가 간결하게 표현되어 있습니다.
Description check ✅ Passed PR 설명이 필수 섹션을 모두 포함하되, 저장소 템플릿의 모든 선택사항을 완전히 채우지는 않았습니다. Summary와 Verification은 명확히 작성되었으나, '관련 이슈', '특이 사항', '리뷰 요구사항'은 누락되었습니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch optimize/bundle-size

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@manNomi manNomi force-pushed the optimize/bundle-size branch from 824621a to e6f7450 Compare February 14, 2026 10:39
@github-actions github-actions bot added the web label Feb 14, 2026
@manNomi manNomi closed this Feb 14, 2026
@manNomi manNomi deleted the optimize/bundle-size branch February 14, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wibaek wibaek Awaiting requested review from wibaek wibaek is a code owner

@enunsnv enunsnv Awaiting requested review from enunsnv enunsnv is a code owner

@khwww khwww Awaiting requested review from khwww khwww is a code owner

Assignees

No one assigned

Labels

web

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@manNomi